Adding an option for the bacula file daemon to support custom message types #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mi-reichel
force-pushed
the
mir_bacula-fd_messages_contrib
branch
from
c67f0fc to
8e6dd13
Compare
|
Hello, just wanted to ask for the status. Greetings |
smortex
reviewed
Jan 3, 2025
README.md
Outdated
Comment on lines
185
to
196
| ```puppet | ||
| class { 'bacula::client': | ||
| messages => { 'Standard-fd' => { | ||
| daemon => 'fd', | ||
| mname => 'Standard', | ||
| director => "${director}-dir = all, !skipped, !restored", | ||
| append => '"/var/log/bacula/bacula-fd.log" = all, !info, !skipped', | ||
| }, | ||
| }, | ||
| } | ||
| ``` |
There was a problem hiding this comment.
Follow the Puppet Style guide:
Suggested change
| ```puppet | |
| class { 'bacula::client': | |
| messages => { 'Standard-fd' => { | |
| daemon => 'fd', | |
| mname => 'Standard', | |
| director => "${director}-dir = all, !skipped, !restored", | |
| append => '"/var/log/bacula/bacula-fd.log" = all, !info, !skipped', | |
| }, | |
| }, | |
| } | |
| ``` | |
| ```puppet | |
| class { 'bacula::client': | |
| messages => { | |
| 'Standard-fd' => { | |
| daemon => 'fd', | |
| mname => 'Standard', | |
| director => "${director}-dir = all, !skipped, !restored", | |
| append => '"/var/log/bacula/bacula-fd.log" = all, !info, !skipped', | |
| }, | |
| }, | |
| } |
.github/CONTRIBUTING.md
Outdated
There was a problem hiding this comment.
Not sure we should keep this file, it is not maintainer by modulesync.
mi-reichel
force-pushed
the
mir_bacula-fd_messages_contrib
branch
from
8e6dd13 to
5467ee2
Compare
|
@smortex |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This adds a message parameter for the client to make customization of the logging configuration possible.
This Pull Request (PR) fixes the following issues
n/a